anchal246 commented on code in PR #6781:
URL: https://github.com/apache/hbase/pull/6781#discussion_r2032413982
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -1513,7 +1518,16 @@ private boolean waitForNamespaceOnline() throws
IOException {
}
return true;
}
+ private void appendZkAclToMasterCoprocessorConf(Configuration conf) {
+ String plugins = conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, "");
+ String zkAclClassName = ZKAclUpdaterCoprocessor.class.getCanonicalName();
+ String accessControllerClassName = conf.get(SECURITY_COPROCESSOR_CONF_KEY,
DEFAULT_SECURITY_COPROCESSOR_CONF_NAME);
+ if ((plugins.contains(accessControllerClassName) ) &&
!plugins.contains(zkAclClassName)) {
+ conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,
+ (plugins.equals("") ? "" : (plugins + ",")) +
ZKAclUpdaterCoprocessor.class.getCanonicalName() );
Review Comment:
We can't have ZKAclUpdaterCoprocessor before AccessController ,as we need
ZKAclUpdaterCoprocessor after AccessController to delete znode associated with
any namespace or table,after a table or znode is deleted .
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java:
##########
@@ -72,6 +72,8 @@ public abstract class CoprocessorHost<C extends Coprocessor,
E extends Coprocess
public static final String SKIP_LOAD_DUPLICATE_TABLE_COPROCESSOR =
"hbase.skip.load.duplicate.table.coprocessor";
public static final boolean DEFAULT_SKIP_LOAD_DUPLICATE_TABLE_COPROCESSOR =
false;
+ public static final String
SECURITY_COPROCESSOR_CONF_KEY="hbase.security.coprocessor";
+ public static final String DEFAULT_SECURITY_COPROCESSOR_CONF_NAME =
"org.apache.hadoop.hbase.security.access.AccessController";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
