[ 
https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435601#comment-13435601
 ] 

stack commented on HBASE-6569:
------------------------------

@Jesse OK. I'm fine w/ keeping logical and implementation distinct -- Store vs 
ColumnFamily.  I'm reacting mostly to the name given the Interface, HStore.  If 
the Interface is to have a letter prefix, can it at least be I for Interface?  
As ugly as this is, it is better than 'H'.  Or StoreInterface?

(Minor point is that Store used to be called HStore.  I worked hard to rename 
it a while ago.  I was trying to undo our prefixing everything w/ the redundant 
'H'. Thats not important)
                
> Extract HStore interface from Store
> -----------------------------------
>
>                 Key: HBASE-6569
>                 URL: https://issues.apache.org/jira/browse/HBASE-6569
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0
>
>         Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the 
> same interface for snapshots (HBASE-6055), and potentially other uses-cases 
> as well, but subclassing is 'dirty' given the amount of state that a Store 
> currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a 
> composition with interface inheritance design very appealing (meaning we need 
> an interface for Store).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to