[ https://issues.apache.org/jira/browse/HBASE-29249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948408#comment-17948408 ]
Hudson commented on HBASE-29249: -------------------------------- Results for branch branch-2 [build #1265 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk17 hadoop3 checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop 3.3.5 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop 3.4.0 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1265/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test for HBase 2 {color} (/) {color:green}+1 client integration test for 3.3.5 {color} (/) {color:green}+1 client integration test for 3.3.6 {color} (/) {color:green}+1 client integration test for 3.4.0 {color} (/) {color:green}+1 client integration test for 3.4.1 {color} > Allow for BlockCache implementations to define dynamic properties > ----------------------------------------------------------------- > > Key: HBASE-29249 > URL: https://issues.apache.org/jira/browse/HBASE-29249 > Project: HBase > Issue Type: Improvement > Affects Versions: 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0, 2.6.2 > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Major > Labels: pull-request-available > Fix For: 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.6.3 > > > We have some customers use case finding useful to have some of the > BucketCache configurations dynamically set, such as the accept factor or the > queue addition wait time. > HBASE-28517 has already made some other cache related properties dynamically > configurable, and CacheConfig already implements the > ConfigurationObserver and registers itself for config changes notifications. > Since CacheConfig holds a reference for the BlockCache implementation, we > could just allow for BlockCache implementation to define their own dynamic > configuration logic by define a refreshConfig method in the BlockCache > interface that would get called from CacheConfig.onConfigurationChange(). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)