stoty commented on PR #6987: URL: https://github.com/apache/hbase/pull/6987#issuecomment-2877052814
> I'm not sure whether we should initialize zookeeper when calling getZooKeeper, as returning null also indicate that there is no request yet, and can be used to as a test condition. > > But anyway, since this class is IA.Private, we are OK to change the behavior if it does not break anything, just more javadoc to explain the logic. None of the existing code uses it like that. All of the callers are using the returned ZK objects to perform operations on it, as that's how it used to work before your last change. I think that ideally getZokkeper() would throw an exception just like most other RecoverableZooKeeper methods, but the callers aren't expecting that, and I didn't want to makemore changes to handle re-tries etc in all of the callers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
