NihalJain commented on code in PR #7043:
URL: https://github.com/apache/hbase/pull/7043#discussion_r2113422677
##########
hbase-build-configuration/pom.xml:
##########
@@ -82,6 +82,8 @@
<arg>-XDcompilePolicy=simple</arg>
<!-- All -Xep need to be on single line see:
https://github.com/google/error-prone/pull/1115 -->
<arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode
-XepExcludedPaths:.*/target/.* -Xep:FallThrough:OFF -Xep:MutablePublicArray:OFF
-Xep:ClassNewInstance:ERROR -Xep:MissingDefault:ERROR -Xep:BanJNDI:WARN</arg>
+ <!-- Required by error prone >= 2.36.0. See
https://github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd
!-->
Review Comment:
Yes @taklwu you are right. We actually move to 2.36.0 but since branch 2
still uses jdk11 for error prone we downgraded. We did not remove these to keep
code as much in sync with master and having this did not have any adverse
effect. Current this line should be a no op for the versiom of error prone we
are on, in branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
