[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437158#comment-13437158
]
stack commented on HBASE-5937:
------------------------------
bq. In the case we make them part of the interface, we will need to find a way
of making an HLog object available in those places.
If these are HLog reader and writers, yeah, should be in the HLog interface I'd
say rather than in an HLogUtil. Can you factory it in places like
HLogInputFormat?
Why move HLog defines into HLogUtil? They seem like core defines rather than
util defines: e.g. HLog.SPLITTING_EXT.
Yeah, this seems like a basic one that needs solving:
{code}
- reader = HLog.getReader(this.fs, edits, conf);
+ reader = HLogUtil.getReader(this.fs, edits, conf);
{code}
You'll need a 'wal' object, one that has been appropriately created dependent
on what WAL engine has been put in place.
Can you not get HLogFactory.createHLog into the places where we have getReader
now -- e.g. in HRegion (Should HRegion even be concerned w/ HLog/WAL? Only
RegionServer should be?)?
Whats FSLog? An HDFSLog?
Should HLog Interface be instead named WAL?
Is it right that the HLog Interface takes an fs? That OK for you lads? You'll
be doing a bookkeeper FS?
HLog Interface seems fat. We need all those methods?
Seems good so far?
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
