Apache9 commented on code in PR #6951:
URL: https://github.com/apache/hbase/pull/6951#discussion_r2119177309


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java:
##########
@@ -83,6 +86,23 @@ public class ReopenTableRegionsProcedure
   private long regionsReopened = 0;
   private long batchesProcessed = 0;
 
+  /**
+   * Create a new ReopenTableRegionsProcedure respecting the throttling 
configuration for the table.
+   * First check the table descriptor, then fall back to the global 
configuration. Only used in
+   * ModifyTableProcedure.
+   */
+  public static ReopenTableRegionsProcedure throttled(final Configuration conf,
+    final TableDescriptor desc) {
+    long backoffMillis = 
Optional.ofNullable(desc.getValue(PROGRESSIVE_BATCH_BACKOFF_MILLIS_KEY))

Review Comment:
   Pity we do not return Optional for desc.getValue...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to