Copilot commented on code in PR #7052:
URL: https://github.com/apache/hbase/pull/7052#discussion_r2119199212
##########
hbase-diagnostics/src/test/java/org/apache/hadoop/hbase/TestPerformanceEvaluation.java:
##########
@@ -403,4 +404,30 @@ boolean testRow(long i, long startTime) throws
IOException, InterruptedException
return false;
}
}
+
+ @Test
+ public void testParseBooleanFlags() {
+ final Queue<String> opts = new LinkedList<>();
+ opts.offer("--valueRandom");
+ opts.offer("--autoFlush"); // default: false
+ opts.offer("--inmemory=true"); // default: false
+ opts.offer("--writeToWAL=false"); // default: true
+ opts.offer(PerformanceEvaluation.RANDOM_READ);
+ opts.offer("1");
+
+ final PerformanceEvaluation.TestOptions options =
PerformanceEvaluation.parseOpts(opts);
+ assertTrue(options.valueRandom);
+ assertTrue(options.flushCommits);
Review Comment:
The test provides '--autoFlush' as an option but asserts that 'flushCommits'
is true. This appears inconsistent—either the test should assert 'autoFlush' or
the option mapping should be updated.
```suggestion
assertTrue(options.flushCommits); // verify flushCommits is true when
--autoFlush=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
