[ https://issues.apache.org/jira/browse/HBASE-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955778#comment-17955778 ]
Hudson commented on HBASE-29283: -------------------------------- Results for branch branch-2.6 [build #322 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop3 checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop 3.3.5 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk17 hadoop 3.4.0 backward compatibility checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/322/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test for HBase 2 {color} (/) {color:green}+1 client integration test for 3.3.5 {color} (/) {color:green}+1 client integration test for 3.3.6 {color} (/) {color:green}+1 client integration test for 3.4.0 {color} (/) {color:green}+1 client integration test for 3.4.1 {color} > Replication MetricsSource.sizeOfHFileRefsQueue metrics not updated correctly > after remove_peer > ---------------------------------------------------------------------------------------------- > > Key: HBASE-29283 > URL: https://issues.apache.org/jira/browse/HBASE-29283 > Project: HBase > Issue Type: Bug > Reporter: Chandra Sekhar K > Assignee: Chandra Sekhar K > Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.3, 2.5.12 > > > in Replication MetricsSource, the value of lastHFileRefsQueueSize not > incremented correctly, due to this the corresponding decrement in > decrSizeOfHFileRefsQueue functions resulting in wrong value. > > {code:java} > public void incrSizeOfHFileRefsQueue(long size) { > singleSourceSource.incrSizeOfHFileRefsQueue(size); > globalSourceSource.incrSizeOfHFileRefsQueue(size); > lastHFileRefsQueueSize = size; //issue here as the value not appended with > previous value > } > public void decrSizeOfHFileRefsQueue(int size) { > singleSourceSource.decrSizeOfHFileRefsQueue(size); > globalSourceSource.decrSizeOfHFileRefsQueue(size); > lastHFileRefsQueueSize -= size; // this results in wrong value > if (lastHFileRefsQueueSize < 0) { > lastHFileRefsQueueSize = 0; > } > }{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)