junegunn commented on code in PR #7108:
URL: https://github.com/apache/hbase/pull/7108#discussion_r2170557268


##########
conf/hadoop-metrics2-hbase.properties:
##########
@@ -14,31 +14,38 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# syntax: [prefix].[source|sink].[instance].[options]
-# See javadoc of package-info.java for org.apache.hadoop.metrics2 for details
+## syntax: [prefix].[source|sink].[instance].[options]
+## See javadoc of package-info.java for org.apache.hadoop.metrics2 for details
 
-*.sink.file*.class=org.apache.hadoop.metrics2.sink.FileSink
-# default sampling period
+## Default sampling period, in seconds
 *.period=10
 
-# Below are some examples of sinks that could be used
-# to monitor different hbase daemons.
+## You can use regular expressions to exclude metrics you don't need.
+
+# 
hbase.source.metric.filter.class=org.apache.hadoop.metrics2.filter.RegexFilter
+# 
hbase.source.metric.filter.exclude=.*_((25|75|90|95|98)th_percentile|min|mean)

Review Comment:
   With this configuration, the scraping time of 
[jmx_exporter](https://github.com/prometheus/jmx_exporter) was significantly 
reduced on some of our regionservers. I believe others could also benefit from 
applying a similar configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to