[
https://issues.apache.org/jira/browse/HBASE-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438135#comment-13438135
]
stack commented on HBASE-6524:
------------------------------
@Jonathan Sorry for delayed review. Thanks for looking at the findbugs and
javac stuff. Probably not you as you figured.
On the patch:
You change hbase-site.xml license indent. Would suggest you don't do that. I
can fix that on commit.
Is htrace up in mvn central?
Why do we create a new instance of TInfo here rather than just use the one we
have (presuming hasTinfo means the request has a TInfo?)?
+ call = new Call(id, param, this, responder, callSize, new TraceInfo(
+ request.getTinfo().getTraceId(),
request.getTinfo().getParentId()));
Should say what a spanReceiverHost is. When I load receivers, what kind of
resources are we allocating?
Is that all it takes to add tracing? That is pretty sweet. I'd say this patch
is close to commit. See comments above. You going to do a bit of a blog w/
fancy tracing pictures? Something we could reference from the refguide? Any
more pretty pictures for us?
> Hooks for hbase tracing
> -----------------------
>
> Key: HBASE-6524
> URL: https://issues.apache.org/jira/browse/HBASE-6524
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Leavitt
> Attachments: htracehooks1.diff
>
>
> Includes the hooks that use [htrace|http://www.github.com/cloudera/htrace]
> library to add dapper-like tracing to hbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
