Umeshkumar9414 commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2190203129
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -73,6 +80,16 @@ protected RecoveredEditsWriter
createRecoveredEditsWriter(TableName tableName, b
return new RecoveredEditsWriter(region, regionEditsPath, w, seqId);
}
+ private String getWorkerNameComponent() {
+ if (walSplitter.rsServices == null) {
+ return "";
+ }
+ return URLEncoder.encode(
+ walSplitter.rsServices.getServerName().toShortString()
Review Comment:
My concern here is that we might breach the file name limit if we use
serverName. So I picked this way to shorten the name somehow.
> And It seems that when creating WAL directories, we do not use
URLEncoder...
Yeah while creating WAL directories we don't use URLEncoder. Not sure if we
should. But we do use URLEncoder for WAL file name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
