[
https://issues.apache.org/jira/browse/HBASE-29441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18007636#comment-18007636
]
Tak-Lon (Stephen) Wu commented on HBASE-29441:
----------------------------------------------
merged
https://github.com/apache/hbase/commit/cb9edf9fd2a77d1a45bda89b217851f1a4c8c802
> ReplicationSourceShipper should delegate the empty wal entries handling to
> ReplicationEndpoint
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-29441
> URL: https://issues.apache.org/jira/browse/HBASE-29441
> Project: HBase
> Issue Type: Task
> Affects Versions: HBASE-28957
> Reporter: Vinayak Hegde
> Assignee: Vinayak Hegde
> Priority: Major
> Labels: pull-request-available
> Fix For: HBASE-28957
>
>
> In {{{}ReplicationSourceShipper#shipEdits{}}}, we currently return
> {{COMMITED}} when the WAL entry list is empty. This can incorrectly advance
> replication offsets, especially if previously submitted entries were not yet
> durably persisted (e.g., still in open WAL files on S3).
> We should return {{SUBMITTED}} in such cases and only return {{COMMITED}}
> when we know data is safely persisted, like on WAL close.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
