taklwu commented on code in PR #7166:
URL: https://github.com/apache/hbase/pull/7166#discussion_r2220663178
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##########
@@ -473,8 +485,11 @@ public List<BulkLoad> readBulkloadRows(List<TableName>
tableList) throws IOExcep
path = Bytes.toString(CellUtil.cloneValue(cell));
}
}
- result.add(new BulkLoad(table, region, fam, path, row));
- LOG.debug("found orig " + path + " for " + fam + " of table " +
region);
+ LOG.debug("found orig {} for {} of table {} with timestamp {}",
path, fam, region,
Review Comment:
nit adjust the short form to clear wording
```suggestion
LOG.debug("found original path {} for column family {} of table {}
with timestamp {}", path, fam, region,
```
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##########
@@ -457,8 +467,10 @@ public List<BulkLoad> readBulkloadRows(List<TableName>
tableList) throws IOExcep
String path = null;
String region = null;
byte[] row = null;
+ long timestamp = 0L;
for (Cell cell : res.listCells()) {
row = CellUtil.cloneRow(cell);
+ timestamp = cell.getTimestamp();
Review Comment:
so is this timestamp the `IncrCommittedWalTs`? I cannot find other timestamp
representing it but it looks like this PR share the same setup as
https://github.com/apache/hbase/pull/7150 that used the BulkLoad#timestamp as
`IncrCommittedWalTs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
