[
https://issues.apache.org/jira/browse/HBASE-6606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440699#comment-13440699
]
Hadoop QA commented on HBASE-6606:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542183/HBASE-6606-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2672//console
This message is automatically generated.
> Test for reconnecting with HBaseAdmin using unmanaged HConnection
> -----------------------------------------------------------------
>
> Key: HBASE-6606
> URL: https://issues.apache.org/jira/browse/HBASE-6606
> Project: HBase
> Issue Type: Task
> Components: client, test
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6606.patch, HBASE-6606-v2.patch
>
>
> HBASE-5058 allowed HBaseAdmin to work with an existing and unmanaged
> HConnection. The retry semantics of managed vs unmanaged connections are
> different. From the JIRA:
> "For an HConnection that is passed from the outside, it has to be possible to
> try again. So if the HConnection is managed we retain the old behavior (i.e.
> only try once, give up after that, even if that failed).
> For an unmanaged connection we try again unless we actually found a master. ."
> I couldn't find any test of this behavior, only that the HBaseAdmin works
> with an unmanaged connection, i.e. no retry testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
