PDavid commented on code in PR #7386:
URL: https://github.com/apache/hbase/pull/7386#discussion_r2429858549
##########
pom.xml:
##########
@@ -2846,22 +2857,56 @@
<configuration>
<artifactItems>
<artifactItem>
- <groupId>io.github.devacfr.maven.skins</groupId>
- <artifactId>reflow-default-webdeps</artifactId>
- <version>${reflow-maven-skin.version}</version>
- <type>jar</type>
- <overWrite>false</overWrite>
- <includes>**/css/bootstrap.min.css,
- **/css/themes/litera/bootstrap.min.css,
- **/css/fontawesome/*,
- **/css/fontawesome/webfonts/*,
- **/js/*.js,
- **/js/languages/*,
- **/js/styles/github.min.css,
- **/js/styles/default.min.css</includes>
+ <groupId>org.webjars</groupId>
+ <artifactId>bootstrap</artifactId>
+ <version>${site.bootstrap.version}</version>
+ <includes>**/js/bootstrap.min.js</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>popper.js</artifactId>
+ <version>${site.popperjs.version}</version>
+ <includes>**/umd/popper.min.js</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>jquery</artifactId>
+ <version>${site.jquery.version}</version>
+ <includes>**/jquery.min.js</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>anchorjs</artifactId>
+ <version>${site.anchorjs.version}</version>
+ <includes>**/anchor.min.js</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>font-awesome</artifactId>
+ <version>${site.fontawesome.version}</version>
+ <includes>**/css/all.min.css,**/webfonts/*</includes>
</artifactItem>
</artifactItems>
-
<outputDirectory>${project.build.directory}/site</outputDirectory>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <version>${maven-download-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>download-litera-bootstrap-theme</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+
<url>https://stackpath.bootstrapcdn.com/bootswatch/${site.bootswatch.version}/litera/bootstrap.min.css</url>
Review Comment:
Many thanks, very good question. There are bootswatch webjars but not for
this exact version. I requested it
https://github.com/webjars/webjars-classic/issues/20
If that is done, I can replace this with a webjar Maven dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
