Andrew Kyle Purtell created HBASE-29680:
-------------------------------------------

             Summary: release-util.sh should not hardcode JAVA_HOME for spotless
                 Key: HBASE-29680
                 URL: https://issues.apache.org/jira/browse/HBASE-29680
             Project: HBase
          Issue Type: Bug
          Components: build
            Reporter: Andrew Kyle Purtell
            Assignee: Andrew Kyle Purtell


We have this in release-util.sh

{noformat}
# Run mvn spotless:apply to format the code base                                
                                                                       
# For 2.x, the generated CHANGES.md and RELEASENOTES.md may have lines end with 
whitespace and                                                         
# case spotless:check failure, so we should run spotless:apply before 
committing                                                                      
 
function maven_spotless_apply() {                                               
                                                                       
  # our spotless plugin version requires at least java 11 to run, so we use 
java 17 here                                                               
  JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64" "${MVN[@]}" spotless:apply     
                                                                       
} 
{noformat}

It should be

...
{noformat}
 JAVA_HOME="$JAVA17_HOME" "${MVN[@]}" spotless:apply
{noformat}
...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to