dev-work-8103 commented on code in PR #7364:
URL: https://github.com/apache/hbase/pull/7364#discussion_r2458925160
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##########
@@ -186,7 +186,10 @@ private void finalizeDelete(List<String> backupRoots,
BackupSystemTable table)
table.deleteIncrementalBackupTableSet(backupRoot);
if (!incrTableSet.isEmpty()) {
- table.addIncrementalBackupTableSet(incrTableSet, backupRoot);
+ // added 1ms to prevent LostUpdate problem in case when
deleteIncrementalBackupTableSet()
+ // executed very fast
+ long ts = EnvironmentEdgeManager.currentTime() + 1;
+ table.addIncrementalBackupTableSet(incrTableSet, backupRoot, ts);
}
}
Review Comment:
Hi @wchevreuil Thanks for the input, I've addressed your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
