guluo2016 commented on code in PR #7410:
URL: https://github.com/apache/hbase/pull/7410#discussion_r2513747505
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java:
##########
@@ -1316,19 +1316,52 @@ private CompletableFuture<Void> compact(TableName
tableName, byte[] columnFamily
switch (compactType) {
case MOB:
- addListener(connection.registry.getActiveMaster(), (serverName, err)
-> {
+ addListener(getDescriptor(tableName), (tableDesc, err) -> {
if (err != null) {
future.completeExceptionally(err);
return;
}
- RegionInfo regionInfo = RegionInfo.createMobRegionInfo(tableName);
- addListener(compact(serverName, regionInfo, major, columnFamily),
(ret, err2) -> {
- if (err2 != null) {
- future.completeExceptionally(err2);
- } else {
- future.complete(ret);
- }
- });
+ List<ColumnFamilyDescriptor> mobColumnFamilies =
+ Arrays.stream(tableDesc.getColumnFamilies())
+ .filter(ColumnFamilyDescriptor::isMobEnabled).toList();
+ if (mobColumnFamilies.isEmpty()) {
+ // It's not a mob table, nothing to do.
+ future.complete(null);
+ return;
+ }
+ if (columnFamily == null) {
Review Comment:
Branch-2 has the same code logic as here, I also verified this on HBase
2.6.2, and the same error occurs.
```bash
hbase:013:0> compact 't1', 'info', 'MOB'
ERROR: org.apache.hadoop.hbase.NotServingRegionException:
t1,.mob,0.78e317a6e78a0fceb27b9fa0cb9dcf5b. is not online on
hbase001,16000,1762860032382
at
org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3675)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3653)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1497)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.compactRegion(RSRpcServices.java:1703)
at
org.apache.hadoop.hbase.master.MasterRpcServices.compactRegion(MasterRpcServices.java:1875)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:34087)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:443)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:105)
at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:85)
For usage try 'help "compact"'
Took 0.0270 seconds
hbase:014:0> version
2.6.2, r6b3b36b429cf9a9d74110de79eb3b327b29ebf17, Fri Feb 14 14:39:16 UTC
2025
Took 0.0000 seconds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
