Umeshkumar9414 commented on code in PR #7490:
URL: https://github.com/apache/hbase/pull/7490#discussion_r2582330822
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java:
##########
@@ -37,16 +37,16 @@ public class BalancedQueueRpcExecutor extends RpcExecutor {
private final QueueBalancer balancer;
public BalancedQueueRpcExecutor(final String name, final int handlerCount,
- final int maxQueueLength, final PriorityFunction priority, final
Configuration conf,
+ final String maxQueueLengthConfKey, final PriorityFunction priority, final
Configuration conf,
Review Comment:
Yes, I agree changing API signature might not work here.
But somehow we have to pass the config value or config key from outside
only. As this same constructor is being used for meta priority handler and
normal handler.
I think adding an new constructor might be a way forword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
