[
https://issues.apache.org/jira/browse/HBASE-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443236#comment-13443236
]
Alex Baranau commented on HBASE-6501:
-------------------------------------
Hi Elliot!
Am I missing something or you did *exactly the same thing* as in patch in this
issue? Except that you named MetricsAsserts as MetricsAssertsHelper. Exactly
same code, same changes in poms :). Note that MetricsAsserts in this patch has
some more handy methods for fetching metrics values _prior to changing it in
test_.
I was very surprised that same changes/pom configs worked for you. But
actually, it seems like they didn't :( From the console output of the build by
Hadoop QA (in HBASE-6412, 28/Aug/12 07:38):
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.1:process (default) on
project hbase-hadoop1-compat: Failed to resolve dependencies for one or more
projects in the reactor. Reason: Missing:
[ERROR] ----------
[ERROR] 1) org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.95-SNAPSHOT
[ERROR]
[ERROR] Try downloading the file manually from the project website.
[ERROR]
[ERROR] Then, install it using the command:
[ERROR] mvn install:install-file -DgroupId=org.apache.hbase
-DartifactId=hbase-hadoop-compat -Dversion=0.95-SNAPSHOT -Dclassifier=tests
-Dpackaging=test-jar -Dfile=/path/to/file
[ERROR]
[ERROR] Alternatively, if you host your own repository you can deploy the file
there:
[ERROR] mvn deploy:deploy-file -DgroupId=org.apache.hbase
-DartifactId=hbase-hadoop-compat -Dversion=0.95-SNAPSHOT -Dclassifier=tests
-Dpackaging=test-jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
[ERROR]
[ERROR] Path to dependency:
[ERROR] 1) org.apache.hbase:hbase-hadoop1-compat:jar:0.95-SNAPSHOT
[ERROR] 2) org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.95-SNAPSHOT
[ERROR]
[ERROR] ----------
[ERROR] 1 required artifact is missing.
{noformat}
So, looks like the issue still there. Unless you know fast way to fix it (or
want to do it right now) I suggest you to extract the tests which use
MetricsAsserts and add them in the patch in this issue (as code is really the
same, it is quite simple). So that we keep these things in one place.
> Integrate with unit-testing tools of hadoop's metrics2 framework
> ----------------------------------------------------------------
>
> Key: HBASE-6501
> URL: https://issues.apache.org/jira/browse/HBASE-6501
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Reporter: Alex Baranau
> Attachments: HBASE-6501_2.patch, HBASE-6501.patch
>
>
> Hadoop's metrics2 framework provides handy tools to write unit-tests for
> metrics sources. E.g. MetricsAsserts class. We want to use that too in HBase
> unit-tests.
> Integration seems straightforward, wowever when integrating this piece we
> faced maven bug: http://jira.codehaus.org/browse/MRRESOURCES-53. Hence we
> decided to extract this into separate issue (originally was done in one of
> the patches of HBASE-6411).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
