ndimiduk commented on code in PR #7563:
URL: https://github.com/apache/hbase/pull/7563#discussion_r2634413275
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java:
##########
@@ -116,12 +136,12 @@ public ReopenTableRegionsProcedure(final TableName
tableName, final List<byte[]>
PROGRESSIVE_BATCH_SIZE_MAX_DISABLED);
}
- ReopenTableRegionsProcedure(final TableName tableName, long
reopenBatchBackoffMillis,
+ public ReopenTableRegionsProcedure(final TableName tableName, long
reopenBatchBackoffMillis,
Review Comment:
If there's going to be a subsequent PR that introduces the integration test,
please wait and make the change then.
Yes, my recollection is that there is a VisibleForTesting on the classpath.
I don't think we use its presence for any static enforcement, but it is useful
enough to communicate intent. IMHO a comment is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
