guluo2016 commented on code in PR #7574:
URL: https://github.com/apache/hbase/pull/7574#discussion_r2639454283


##########
dev-support/flaky-tests/report-flakies.py:
##########
@@ -205,30 +213,30 @@ def expand_multi_config_projects(cli_args):
         bad_tests.update(failed_tests.union(hanging_tests))
 
     # For each bad test, get build ids where it ran, timed out, failed or 
hanged.
-    test_to_build_ids = {key : {'all' : set(), 'timeout': set(), 'failed': 
set(),
-                                'hanging' : set(), 'bad_count' : 0}
-                         for key in bad_tests}
+    for key in bad_tests:
+        test_to_build_ids[key] = {'all': set(), 'timeout': set(), 'failed': 
set(),
+                                  'hanging': set(), 'bad_count': 0}
+
     for build in build_id_to_results:
         [all_tests, failed_tests, timeout_tests, hanging_tests] = 
build_id_to_results[build]
-        for bad_test in test_to_build_ids:
+        for bad_test, test_result in test_to_build_ids:

Review Comment:
   Should use `test_to_build_ids.items()` to iterate over the dict's key-value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to