[
https://issues.apache.org/jira/browse/HBASE-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443648#comment-13443648
]
Alex Baranau commented on HBASE-6412:
-------------------------------------
Thanx Elliott!
bq. we could create a test only module. eg hbase-hadoop1-compat-test |
hbase-hadoop2-compat-test
{noformat}
[ERROR] Path to dependency:
[ERROR] 1) org.apache.hbase:hbase-hadoop1-compat:jar:0.95-SNAPSHOT
[ERROR] 2) org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.95-SNAPSHOT
{noformat}
I.e. hadoopX-compat doesn't see hadoop-compat jar (when it comes to compiling
its test classes). And I guess hbase-server will not see it too.
So if I'm not mistaken you are talking about fixing this by moving metrics
tests to separate hadoopX-compat-Y modules so that there's no shared test-level
classes from another module between them. While this would work, I'd agree with
Elliott and say that I don't like this idea: tests seem to be
specific-hadoop-version-agnostic. We'll have duplicated code. And naturally
this code probably belongs to hbase-server.
I'd not create separate modules just to work around maven bug. We would rather
be slower with "package" and hope that it will be fixed..
> Move external servers to metrics2 (thrift,thrift2,rest)
> -------------------------------------------------------
>
> Key: HBASE-6412
> URL: https://issues.apache.org/jira/browse/HBASE-6412
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Attachments: HBASE-6412-0.patch
>
>
> Implement metrics2 for all the external servers:
> * Thrift
> * Thrift2
> * Rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
