Copilot commented on code in PR #7592:
URL: https://github.com/apache/hbase/pull/7592#discussion_r2663610001
##########
pom.xml:
##########
@@ -1443,6 +1443,11 @@
<artifactId>findbugs-annotations</artifactId>
<version>${findbugs-annotations.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.jcip</groupId>
+ <artifactId>jcip-annotations</artifactId>
+ <version>1.0-1</version>
Review Comment:
There's an inconsistency in the groupId for jcip-annotations. The
supplemental-models.xml file
(hbase-resource-bundle/src/main/resources/supplemental-models.xml) already
references this dependency with groupId "net.jcip", but here you're adding it
with groupId "com.github.stephenc.jcip". While both artifacts exist in Maven
Central, you should verify which one provides the correct package
(net.jcip.annotations) that's being imported in the code. The
"net.jcip:jcip-annotations:1.0" is the original artifact, while
"com.github.stephenc.jcip:jcip-annotations:1.0-1" is a republished version.
Consider using the same groupId that's already documented in
supplemental-models.xml for consistency, unless there's a specific reason to
use the republished version.
```suggestion
<groupId>net.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
<version>1.0</version>
```
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.jcip</groupId>
+ <artifactId>jcip-annotations</artifactId>
+ <scope>compile</scope>
+ <optional>true</optional>
+ </dependency>
Review Comment:
The groupId used here (com.github.stephenc.jcip) is inconsistent with the
groupId referenced in supplemental-models.xml (net.jcip). This inconsistency
could lead to confusion about which artifact is actually being used. Ensure
that the groupId matches what's declared in the root pom.xml's
dependencyManagement section, and consider whether both need to align with the
existing supplemental-models.xml entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
