Copilot commented on code in PR #7625: URL: https://github.com/apache/hbase/pull/7625#discussion_r2692164030
########## hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java: ########## @@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa protected static final int DEFAULT_NUM_ITERATIONS = 10; protected static final int DEFAULT_ROWS_IN_ITERATION = 10000; protected static final String SLEEP_TIME_KEY = "sleeptime"; - // short default interval because tests don't run very long. + // Short default interval because tests don't run very long. protected static final long SLEEP_TIME_DEFAULT = 50000L; protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT"; - protected static int rowsInIteration; - protected static int regionsCountPerServer; - protected static int regionServerCount; + // These test parameters can be configured using a Configuration object or via the command line. + protected static int rowsInIteration = -1; + protected static int regionsCountPerServer = -1; + protected static int regionServerCount = -1; + protected static int numIterations = -1; + protected static int numTables = -1; + protected static long sleepTime = -1; Review Comment: These static variables are shared across all test instances and may cause issues in concurrent test execution. If multiple tests run in parallel (e.g., in a test suite), modifications to these static variables in one test's setUp() method could affect other running tests. Consider making these instance variables instead, or document that these tests cannot be run in parallel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
