[ 
https://issues.apache.org/jira/browse/HBASE-29820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052821#comment-18052821
 ] 

Aman Poonia commented on HBASE-29820:
-------------------------------------

To the doubt why this name didnot fail build. Because this variable is not used 
anywhere. So current PR just maintains consistency. Build is still passing but 
if someone ever uses this variable in vm file it will start failing.

> Bump the syntax of velocity template to align with velocity 2.x syntax
> ----------------------------------------------------------------------
>
>                 Key: HBASE-29820
>                 URL: https://issues.apache.org/jira/browse/HBASE-29820
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-beta-1, 4.0.0-alpha-1, 2.6.4, 2.5.13
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.7.0, 3.0.0-beta-2, 2.6.5, 2.5.14
>
>
> * *Velocity 2.4* disallows hyphens in variable names, requiring template 
> changes.
>  * Updating the syntax now prepares us for upgrading to newer Velocity 
> versions.
>  * This improves compatibility with plugins like 
> {*}maven-remote-resources-plugin{*}, which use the latest Velocity.
>  * The current setup is pinned to {*}Velocity 1.7{*}, while the latest 
> version ({*}3.3.0{*}) runs on the *Velocity 2.x engine* by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to