[ https://issues.apache.org/jira/browse/HBASE-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444507#comment-13444507 ]
Hadoop QA commented on HBASE-6480: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538516/HBASE-6480-trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2729//console This message is automatically generated. > If callQueueSize exceed maxQueueSize, all call will be rejected, do not > reject priorityCall > -------------------------------------------------------------------------------------------- > > Key: HBASE-6480 > URL: https://issues.apache.org/jira/browse/HBASE-6480 > Project: HBase > Issue Type: Bug > Reporter: binlijin > Fix For: 0.96.0, 0.94.2 > > Attachments: HBASE-6480-94.patch, HBASE-6480-trunk.patch > > > Current if the callQueueSize exceed maxQueueSize, all call will be rejected, > Should we let the priority Call pass through? > Current: > {code} > if ((callSize + callQueueSize.get()) > maxQueueSize) { > Call callTooBig = xxx > return ; > } > if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) { > priorityCallQueue.put(call); > updateCallQueueLenMetrics(priorityCallQueue); > } else { > callQueue.put(call); // queue the call; maybe blocked here > updateCallQueueLenMetrics(callQueue); > } > {code} > Should we change it to : > {code} > if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) { > priorityCallQueue.put(call); > updateCallQueueLenMetrics(priorityCallQueue); > } else { > if ((callSize + callQueueSize.get()) > maxQueueSize) { > Call callTooBig = xxx > return ; > } > callQueue.put(call); // queue the call; maybe blocked here > updateCallQueueLenMetrics(callQueue); > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira