Kota-SH commented on code in PR #7558:
URL: https://github.com/apache/hbase/pull/7558#discussion_r2739135775
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -675,6 +675,14 @@ public String toString() {
return getServerName().toString();
}
+ @Override
+ public org.apache.hadoop.hbase.TableName getMetaTableName() {
+ // For now, always return the default meta table name.
+ // Future implementations may support custom meta table names from
configuration or storage.
+ return org.apache.hadoop.hbase.TableName
+
.valueOf(org.apache.hadoop.hbase.NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR,
"meta");
Review Comment:
As RegionServer does not have access to Master Region, I left this as
default here and override the method in HRegionServer to use Connection.
However during bootstrap, we would need meta table name for creating connection
object, so only during bootstrap it falls back to default (here).
Further, when we implement the config for creating the meta table name
suffix, we can add that calculation logic here and pass the name along to
HMaster to store it in Master Region during bootstrap. Please let me know your
thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
