Apache9 commented on PR #7653: URL: https://github.com/apache/hbase/pull/7653#issuecomment-3835538996
> @Apache9 Thank you for the review! > > I've addressed your feedback: > > * [1e6152e](https://github.com/apache/hbase/commit/1e6152e895ffaaa391f5a5696126b1edd6c16485) > * [237dce2](https://github.com/apache/hbase/commit/237dce26cd02fc1b6799c1cce963bda65accc163) > > * The global configuration (`io.storefile.bloom.filter.impl`) was effectively dead code, and column family level configuration should be sufficient for now, so I removed it. > > > So the ribbon filter implementation in this PR is implemented from scratch? > > Yes, this is implemented from scratch based on: > > 1. The original Ribbon Filter [paper](https://arxiv.org/abs/2103.02515) > 2. The reference implementation in [here](https://github.com/FastFilter/fastfilter_cpp) by the paper authors Although we do not use the code directly, I still think we'd better mention this reference implementation at least in the javadoc of our implementation class. The reference implementation is licensed under Apache 2.0, which should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
