richardantal commented on code in PR #7692:
URL: https://github.com/apache/hbase/pull/7692#discussion_r2798215368
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java:
##########
@@ -205,7 +205,7 @@ static void resetController(HBaseRpcController controller,
long timeoutNs, int p
controller.setCallTimeout(
(int) Math.min(Integer.MAX_VALUE,
TimeUnit.NANOSECONDS.toMillis(timeoutNs)));
}
- controller.setPriority(priority);
+ controller.setPriority(priority, tableName);
Review Comment:
When we call `controller.setPriority(priority, tableName);` on the
`metadataRpcController` which doesn't have a `setPriority(priority, tableName)`
method it results calling the
`DelegatingHBaseRpcController`'s `setPriority(int priority, @Nullable
TableName tableName)` method
It calls the `delegate.setPriority(priority, tableName)` ( not
setPriority(int) and then setPriority(TableName) )
Where the delegate is `HBaseRpcControllerImpl`
So we won't call the `MetadataRpcController`'s `setPriority(TableName)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
