[
https://issues.apache.org/jira/browse/HBASE-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445137#comment-13445137
]
Hadoop QA commented on HBASE-6381:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543121/trunk-6381_v5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 111 warning
messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 10 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2739//console
This message is automatically generated.
> AssignmentManager should use the same logic for clean startup and failover
> --------------------------------------------------------------------------
>
> Key: HBASE-6381
> URL: https://issues.apache.org/jira/browse/HBASE-6381
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: hbase-6381-notes.pdf, trunk-6381_v5.patch
>
>
> Currently AssignmentManager handles clean startup and failover very
> differently.
> Different logic is mingled together so it is hard to find out which is for
> which.
> We should clean it up and share the same logic so that AssignmentManager
> handles
> both cases the same way. This way, the code will much easier to understand
> and
> maintain.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
