droudnitsky commented on code in PR #7764:
URL: https://github.com/apache/hbase/pull/7764#discussion_r2820645790
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:
##########
@@ -964,9 +964,9 @@ protected boolean trySkipToNextColumn(ExtendedCell cell)
throws IOException {
} while ((nextCell = this.heap.peek()) != null &&
CellUtil.matchingRowColumn(cell, nextCell));
// We need this check because it may happen that the new scanner that we
get
// during heap.next() is requiring reseek due of fake KV previously
generated for
- // ROWCOL bloom filter optimization. See HBASE-19863 for more details
+ // ROWCOL bloom filter optimization. See HBASE-19863 and HBASE-29907 for
more details
if (
- useRowColBloom && nextCell != null && cell.getTimestamp() ==
PrivateConstants.OLDEST_TIMESTAMP
+ useRowColBloom && nextCell != null &&
matcher.compareKeyForNextColumn(nextCell, cell) < 0
Review Comment:
for reference,
[this](https://github.com/apache/hbase/pull/5379/changes#diff-89d4b6565ec9dec236166627df178725ab7978e538809443fb9ea309d94df44eL938)
is the original change introduced in #5379 that is being reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
