Apache9 commented on code in PR #7782:
URL: https://github.com/apache/hbase/pull/7782#discussion_r2839122149
##########
hbase-shaded/pom.xml:
##########
@@ -537,6 +537,16 @@
<exclude>keytab.txt</exclude>
</excludes>
</filter>
+ <filter>
+ <!-- We are not ready to use JDK 25 yet, and these classes
cause shading
+ errors on older ASM versions.
+ Safe to remove if upgrading the shade plugin to 3.6.1
or later.
+ -->
+ <artifact>com.dynatrace.hash4j:hash4j</artifact>
+ <excludes>
+ <exclude>META-INF/versions/25/**</exclude>
+ </excludes>
+ </filter>
Review Comment:
We can bump the shade plugin version, altough we only test on JDK17
official, as far as I know lots of our users have already run HBase with JDK21,
so maybe there are users want to run HBase with JDK25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
