[
https://issues.apache.org/jira/browse/HBASE-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445606#comment-13445606
]
Hadoop QA commented on HBASE-6647:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543159/HBASE-6647.pach
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 110 warning
messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 11 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2748//console
This message is automatically generated.
> [performance regression] appendNoSync/HBASE-4528 doesn't take deferred log
> flush into account
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-6647
> URL: https://issues.apache.org/jira/browse/HBASE-6647
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6647-0.94.patch, HBASE-6647-0.94-v2.patch,
> HBASE-6647-0.94-v3.patch, HBASE-6647.pach
>
>
> Since we upgraded to 0.94.1 from 0.92 I saw that our ICVs are about twice as
> slow as they were. jstack'ing I saw that most of the time we are waiting on
> sync()... but those tables have deferred log flush turned on so they
> shouldn't even be calling it.
> HTD.isDeferredLogFlush is currently only called in the append() methods which
> are pretty much not in use anymore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
