[ 
https://issues.apache.org/jira/browse/HBASE-29966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063897#comment-18063897
 ] 

Duo Zhang commented on HBASE-29966:
-----------------------------------

OK, the problem is that FlushRegionProcedure does not inherit 
ServerRemoteProcedure, and it did not deal with the race correctly, which 
causes FlushTableProcedure hang forever.

Following the pattern in ServerRemoteProcedure to add synchronized to some 
methods can fix the problem.

But anyway, let's also rewrite TestAcidGuarantees with junit5 and parameterized 
to make the coder cleaner.

> Fix race in FlushRegionProcedure and rewrite TestAcidGuarantees
> ---------------------------------------------------------------
>
>                 Key: HBASE-29966
>                 URL: https://issues.apache.org/jira/browse/HBASE-29966
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Duo Zhang
>            Priority: Major
>
> It has 6 test methods in it, which are all very heavy and easy to fail in pre 
> commit check.
> Let's split it, so we can know which test is the most flaky one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to