liuxiaocs7 commented on code in PR #7887: URL: https://github.com/apache/hbase/pull/7887#discussion_r2906468594
########## hbase-server/src/test/java/org/apache/hadoop/hbase/MiniClusterExtension.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.function.Supplier; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.client.AsyncConnection; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.ConnectionFactory; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.Extension; +import org.junit.jupiter.api.extension.ExtensionContext; + +/** + * An {@link Extension} that manages an instance of the {@link SingleProcessHBaseCluster}. Built on + * top of an instance of {@link HBaseTestingUtil}, so be weary of intermixing direct use of that + * class with this Extension. + * </p> + * Use in combination with {@link ConnectionExtension}, for example: + * + * <pre> + * { + * @code + * public class TestMyClass { + * + * @RegisterExtension + * public static final MiniClusterExtension miniClusterExtension = + * MiniClusterExtension.newBuilder().build(); + * + * @RegisterExtension + * public final ConnectionExtension connectionExtension = ConnectionExtension + * .createAsyncConnectionExtension(miniClusterExtension::createAsyncConnection); + * } + * } + * </pre> + */ +public final class MiniClusterExtension implements BeforeAllCallback, AfterAllCallback { Review Comment: We use `MiniClusterExtension` in `TestCoprocessorEndpointTracing`, same as `ConnectionExtension` ########## hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpointTracing.java: ########## @@ -118,39 +124,31 @@ public class TestCoprocessorEndpointTracing { ProtobufCoprocessorService.class.getName()); return conf; }).build(); - private static final ConnectionRule connectionRule = - ConnectionRule.createAsyncConnectionRule(miniclusterRule::createAsyncConnection); - Review Comment: we use `MiniClusterExtension` to replace `MiniClusterRule` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
