[
https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446609#comment-13446609
]
stack commented on HBASE-6659:
------------------------------
bq. I searched AssignmentManager and don't see regions field.
My bad. It was in 0.94. Its not in trunk (Jimmy removed it recently)
bq. w.r.t. adding updateLastFlushedSequenceIds(), the current formation of the
patch is due to the fact that regionServerReport() is in ServerManager.
ServerManager is marked @InterfaceAudience.Private, so ServerManager needs to
deliver status update to HMaster.
I do not follow. What is the above justifying?
Should the map of sequenceids to regions be in ServerManager and not in Master
so you don't have to leak it out to the HMaster wrapper class? (Would this
mean you would not have to add updateLastFlushedSequenceIds to MasterServices?
ServerManager deals w/ Load as it is... its tough because this stuff is so
messy... load is carrying non-load attributes... keeping the mess confined to
SM would be a bit of improvement over having to pass info from HMaster to SM
and then back to HMaster)
bq. Could we put the rpc behind an Interface at least?
What I meant is would it make sense making an Interface named LastSequenceId
whose content was a method named:
long getLastSequenceId(regionname);
Its implementation would have RS invoke method on Master but at least we'd be
making it so HLogSplitter didn't have to be polluted w/ some protocol
implementation. Interface would also make it easier testing HLogSplitter.
I took a look at v7. Most of my comments above are informed by a review of it
up in rb
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
> Key: HBASE-6659
> URL: https://issues.apache.org/jira/browse/HBASE-6659
> Project: HBase
> Issue Type: Bug
> Reporter: Zhihong Ted Yu
> Assignee: Zhihong Ted Yu
> Fix For: 0.96.0
>
> Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt,
> 6508-v7.txt, 6508-v7.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
