wchevreuil commented on code in PR #8058: URL: https://github.com/apache/hbase/pull/8058#discussion_r3072513409
########## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ClientConnectionRegistry.java: ########## Review Comment: Another reason to try integrate this into the already existing client metrics: MetricsUserAggregateImpl already provides its own maps and tracking mechanisms, which would dismiss the need for changes in the rpc layer. ########## hbase-protocol-shaded/src/main/protobuf/server/ClusterStatus.proto: ########## Review Comment: There's already a ClientMetrics object defined in ClusterStatus.proto, which is used by the hbtop tool to provide some client related information. I think we should add these there and reuse that object on this UI, while also update hbtop to report the additional information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
