bjomobo commented on code in PR #8013: URL: https://github.com/apache/hbase/pull/8013#discussion_r3074341200
########## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestRestoreSnapshotProcedureFileBasedSFT.java: ########## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.procedure; + +import static org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.TRACKER_IMPL; +import static org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.Trackers.FILE; +import static org.junit.Assert.assertTrue; + +import java.io.IOException; +import java.util.List; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseTestingUtil; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.Put; +import org.apache.hadoop.hbase.client.RegionInfo; +import org.apache.hadoop.hbase.client.Table; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils; +import org.apache.hadoop.hbase.testclassification.LargeTests; +import org.apache.hadoop.hbase.testclassification.MasterTests; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.CommonFSUtils; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Integration test for RestoreSnapshotProcedure with FileBasedStoreFileTracker. Verifies the + * end-to-end restore snapshot flow works correctly when the FILE-based StoreFileTracker is in use. + * Uses HBaseTestingUtil to start an in-process mini HBase cluster to exercise the restoreRegion() + * code path in RestoreSnapshotHelper. + */ +@Category({ MasterTests.class, LargeTests.class }) +public class TestRestoreSnapshotProcedureFileBasedSFT { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestRestoreSnapshotProcedureFileBasedSFT.class); + + private static final Logger LOG = + LoggerFactory.getLogger(TestRestoreSnapshotProcedureFileBasedSFT.class); + + private static final HBaseTestingUtil UTIL = new HBaseTestingUtil(); + private static final byte[] CF = Bytes.toBytes("cf"); + + /** The .filelist directory name used by FileBasedStoreFileTracker. */ + private static final String FILELIST_DIR = ".filelist"; + + @BeforeClass + public static void setupCluster() throws Exception { + Configuration conf = UTIL.getConfiguration(); + // Do NOT set FILE tracker globally — the bug only manifests when + // global is Default and table-level config is FILE. + conf.setInt(MasterProcedureConstants.MASTER_PROCEDURE_THREADS, 1); + UTIL.startMiniCluster(3); + } + + @AfterClass + public static void tearDownCluster() throws Exception { + UTIL.shutdownMiniCluster(); + } + + /** + * Test that reproduces the scenario where restore fails with FileNotFoundException: 1. Create Review Comment: `TestRestoreSnapshotProcedureFileBasedSFT` tests the end-to-end procedure path (single region, simple data change + compaction scenarios), while `TestRestoreSnapshotFileTrackerTableLevel` uses pre-split regions (4 regions), proper compaction wait via `UTIL.waitFor()`, and covers the multi-family restore path (add/remove column families). Happy to consolidate if you feel strongly, but I kept them separate since they exercise slightly different things -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
