Copilot commented on code in PR #8066: URL: https://github.com/apache/hbase/pull/8066#discussion_r3078795608
########## hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupMajorCompactionTTL.java: ########## @@ -30,25 +29,24 @@ import org.apache.hadoop.hbase.coprocessor.CoprocessorHost; import org.apache.hadoop.hbase.master.HMaster; import org.apache.hadoop.hbase.master.ServerManager; -import org.apache.hadoop.hbase.testclassification.LargeTests; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.testclassification.MiscTests; import org.apache.hadoop.hbase.util.compaction.TestMajorCompactorTTL; -import org.junit.After; -import org.junit.Before; -import org.junit.ClassRule; -import org.junit.Test; -import org.junit.experimental.categories.Category; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; import org.apache.hbase.thirdparty.com.google.common.collect.Lists; -@Category(LargeTests.class) +@Tag(MiscTests.TAG) +@Tag(MediumTests.TAG) Review Comment: This PR is scoped as a JUnit 5 upgrade, but this change also alters the test’s classification from `@Category(LargeTests.class)` to `@Tag(MiscTests.TAG)` and `@Tag(MediumTests.TAG)`, which can affect how/when the test runs in CI and developer workflows. Consider preserving the original classification intent by tagging with `LargeTests.TAG` (and any other equivalent tags) unless there’s a separate justification/issue for reclassifying the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
