anmolnar commented on code in PR #8044: URL: https://github.com/apache/hbase/pull/8044#discussion_r3087238981
########## hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRefreshHFilesFromClient.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import static org.junit.Assert.assertTrue; + +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.NamespaceNotFoundException; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.TableNotFoundException; +import org.apache.hadoop.hbase.TestRefreshHFilesBase; +import org.apache.hadoop.hbase.testclassification.ClientTests; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({ MediumTests.class, ClientTests.class }) +public class TestRefreshHFilesFromClient extends TestRefreshHFilesBase { + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestRefreshHFilesFromClient.class); + + private static final TableName TEST_NONEXISTENT_TABLE = + TableName.valueOf("testRefreshHFilesNonExistentTable"); + private static final String TEST_NONEXISTENT_NAMESPACE = "testRefreshHFilesNonExistentNamespace"; + + @Before + public void setup() throws Exception { + baseSetup(false); + } + + @After + public void tearDown() throws Exception { + baseTearDown(); + } + + @Test + public void testRefreshHFilesForTable() throws Exception { + try { + // Create table in default namespace + createTableAndWait(TEST_TABLE, TEST_FAMILY); + + // RefreshHFiles for table + Long procId = admin.refreshHFiles(TEST_TABLE); + assertTrue(procId >= 0); + } catch (Exception e) { + Assert.fail("RefreshHFilesForTable Should Not Throw Exception: " + e); + throw new RuntimeException(e); + } finally { + // Delete table name post test execution + deleteTable(TEST_TABLE); + } + } + + // Not creating table hence refresh should throw exception + @Test(expected = TableNotFoundException.class) Review Comment: I'm not sure if it's a must, but I believe we should definitely do it in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
