Apache9 commented on PR #8098: URL: https://github.com/apache/hbase/pull/8098#issuecomment-4267540701
As described on the jira issue, in this PR, we only change the ConnectionRegistry when creating Connection instance at client side, in this way, we do not need to restart the cluster when changing the ConnectionRegistry implementation any more. This is acceptable as the test is "TestFromClientSide". In this PR, we 1. Add RpcConnectionRegistry as parameter too, as it is the default registry implementation now. 2. Refactor TestFromClientSide3 to also extends FromClientSideTestBase, to align it with other tests. 3. TestFromClientSide is now TestFromClientSide1. 4. Move testFilterAcrossMultipleRegions to a separate test class because it executes for a long time, which may cause TestFromClientSide1 time out. 5. Remove testUnmanagedHConnection as it does not make sense in the current code base. 6. Move testUnmanagedHConnectionReconnect to a separated test class because it needs special master setup and configurations. 7. Move the test methods which do not need a cluster to a separated test class TestClientDataStructureMisc. 8. Make TestTableScanMetrics not extends FromClientSideBase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
