EungsopYoo commented on code in PR #7901:
URL: https://github.com/apache/hbase/pull/7901#discussion_r3167738038
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowCache.java:
##########
@@ -63,8 +85,8 @@ <R> R execute(RowOperation<R> operation) throws IOException {
RowCache(Configuration conf) {
enabledByConf =
conf.getFloat(HConstants.ROW_CACHE_SIZE_KEY,
HConstants.ROW_CACHE_SIZE_DEFAULT) > 0;
- // TODO: implement row cache
- rowCacheStrategy = null;
+ // Currently we only support TinyLfu implementation
+ rowCacheStrategy = new
TinyLfuRowCacheStrategy(MemorySizeUtil.getRowCacheSize(conf));
Review Comment:
Done. Introduced `row.cache.strategy.class` config key so a custom
`RowCacheStrategy` can be plugged in via configuration; default remains
`TinyLfuRowCacheStrategy`. This follows the same convention used by `MemStore`
and `RegionSplitPolicy` (`Configuration`-arg constructor +
`ReflectionUtils.newInstance`).
Commit:
https://github.com/apache/hbase/pull/7901/commits/6739f062accbde26671deaee01b59cfc1fb3d693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
