mnpoonia commented on PR #7679:
URL: https://github.com/apache/hbase/pull/7679#issuecomment-4366010225
> Async profiler is an optional dependency. The availability of a profiler
on the server side can be a security risk and so some (or many) may opt not to
place one there. This change does not gracefully handle the absence of the
profiler nor make its deployment optional.
Good point. This PR addresses both concerns: the dependency is now marked
<optional>true</optional> so it is never transitively pulled into downstream
modules. Users who want to bundle it can activate
the async-profiler Maven profile (-Pasync-profiler). Absence is handled
gracefully — HttpServer checks ProfileServlet.isAvailable() at startup and
falls back to DisabledServlet (returning HTTP 500
with a clear message) when neither the JAR nor ASYNC_PROFILER_HOME is
present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
