mini666 commented on PR #8030: URL: https://github.com/apache/hbase/pull/8030#issuecomment-4411027063
@junegunn Pushed an amended commit `a24eb390bf`. The failure was in `TestSnapshotDescriptionUtils#testValidateMissingTableName`, which expects `validate(SnapshotDescription, Configuration)` to throw `IllegalArgumentException` immediately when the description has no table, without performing any I/O — a property the previous master code had. After this PR, the new wrapper called `ConnectionFactory.createConnection(conf)` first, which eagerly bootstraps a master RPC and fails with `ConnectException` (against a stub `Configuration(false)`) before the inner `hasTable()` check in the new 3-arg overload could throw. The fix is to do the same fail-fast check in the wrapper before paying the connection setup cost. Verified locally: - `TestSnapshotDescriptionUtils` 5/5 - `TestSnapshotManager` 4/4 - `TestSnapshotFromMaster` 8/8 The `large-wave-1` failures from the previous run (`TestHRegion` parallel tests, `TestEditsBehindDroppedTableTiming`) appear unrelated to this PR's scope and look like known flaky tests; expect them to clear on the rerun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
