[
https://issues.apache.org/jira/browse/HBASE-30155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Liu updated HBASE-30155:
-----------------------------
Status: Patch Available (was: In Progress)
> MobFileCleanerChore does not shut down its internal executor on cleanup
> -----------------------------------------------------------------------
>
> Key: HBASE-30155
> URL: https://issues.apache.org/jira/browse/HBASE-30155
> Project: HBase
> Issue Type: Bug
> Components: mob
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.5.15, 2.6.6
>
>
> {\{MobFileCleanerChore}} creates its own \{{ThreadPoolExecutor}} for cleaning
> MOB files in parallel, but it does not override \{{ScheduledChore.cleanup()}}
> to shut down the executor.
> {\{HMaster.stopChores()}} calls \{{shutdownChore(mobFileCleanerChore)}},
> which eventually invokes \{{ScheduledChore.shutdown()}} and then
> \{{cleanup()}}. However, the default \{{ScheduledChore.cleanup()}}
> implementation is empty, so the \{{mobfile-cleaner-pool-*}} threads created
> by \{{MobFileCleanerChore}} are left running after the chore is shut down.
> The fix is to override \{{cleanup()}} in \{{MobFileCleanerChore}} and shut
> down the internal executor, for example by calling
> \{{executor.shutdownNow()}}. A unit test should verify that
> \{{MobFileCleanerChore.shutdown()}} shuts down the executor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
