sanjeet006py commented on code in PR #8236:
URL: https://github.com/apache/hbase/pull/8236#discussion_r3241418796


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionLocator.java:
##########
@@ -130,6 +131,44 @@ default List<HRegionLocation> getRegionLocations(byte[] 
row) throws IOException
    */
   List<HRegionLocation> getAllRegionLocations() throws IOException;
 
+  /**
+   * Bulk lookup of region locations from {@code hbase:meta} in a single RPC, 
starting at
+   * {@code startKey} (region start-key boundary, inclusive) and returning at 
most {@code limit}
+   * regions in start-key order.
+   * <p/>
+   * The returned list includes all replicas of each region (matching
+   * {@link #getAllRegionLocations()}), and the result is also written to the 
connection's region
+   * location cache.
+   * <p/>
+   * Ordering: regions are returned in ascending region start-key order (the 
natural order of
+   * {@code hbase:meta} rows for a single table). Within each region, replicas 
are returned in
+   * ascending replica-id order (replica 0, then 1, then 2, ...). Split 
parents and offline regions
+   * are filtered out, which may cause a page to contain fewer than {@code 
limit} regions but never

Review Comment:
   Filtering is already implemented and happens in inside 
`MetaTableAccessor.DefaultVisitorBase#visit()`. Call chain: 
`HRegionLocator#getRegionLocations()` -> 
`MetaTableAccessor.TableVisitorBase#visit()` -> 
`MetaTableAccessor.DefaultVisitorBase#visit()`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to