ankitsol commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r3333407853
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -134,6 +186,15 @@ public final void run() {
}
private void noMoreData() {
+ try {
+ // Flush any delayed offset before finishing queue
+ persistLogPosition();
+ } catch (IOException e) {
+ LOG.error("Failed to persist final replication offset for
walGroupId={}", walGroupId, e);
+ abortAndRestart(e);
Review Comment:
Agreed. I will remove handling from here. Only run() will handle all persist
exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
