taklwu commented on code in PR #8325:
URL: https://github.com/apache/hbase/pull/8325#discussion_r3406063310
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/cache/CacheWriteSource.java:
##########
@@ -35,6 +35,16 @@ public enum CacheWriteSource {
*/
READ_MISS,
+ /**
+ * Block was inserted from the HFile write/cache-on-write path.
+ * <p>
+ * This source covers write-side population where the caller does not expose
whether the HFile is
+ * being produced by flush, compaction, bulk load, or another writer. More
specific write-side
+ * sources can be added later when that context is available at the call
site.
+ * </p>
+ */
+ WRITE_PATH,
+
Review Comment:
nit: I got this is a new type, but in this PR, we didn't use it and IMO we
should add new type when it's being used?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLazyDataBlockDecompression.java:
##########
@@ -132,6 +132,10 @@ private static void cacheBlocks(Configuration conf,
CacheConfig cacheConfig, Fil
reader.close();
}
+ /*
+ * TODO: migrate this test to use new HBASE-30018 APIs and remove the need
to cast to
+ * LruBlockCache
+ */
Review Comment:
nit: if you have plan to update it , we can have this in the upcoming JIRA
without this reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
